Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADAP-1116: Move to hatch and pyproject.toml #1407

Merged
merged 23 commits into from
Dec 11, 2024
Merged

ADAP-1116: Move to hatch and pyproject.toml #1407

merged 23 commits into from
Dec 11, 2024
+657 −444

Conversation

mikealfare
Copy link
Contributor

We are moving to a monorepo that uses pyproject.toml and hatch. This requires a series of migrations, including this one. This PR inclues:

  • update from setup.py/dev-requirements.txt to pyproject.toml/hatch.toml
  • move tool config (e.g. mypy and pytest) into pyproject.toml
  • update workflows regarding these moves
  • delete configs that no longer apply (e.g. tox.ini, pytest.ini, etc.)

@mikealfare mikealfare self-assigned this Nov 18, 2024
@cla-bot cla-bot bot added the cla:yes label Nov 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

@mikealfare
Copy link
Contributor Author

Since integration tests are target based, and this PR updates integration tests, here's the appropriate run: https://github.com/dbt-labs/dbt-bigquery/actions/runs/11884221296

@mikealfare mikealfare marked this pull request as ready for review November 18, 2024 02:06
@mikealfare mikealfare requested a review from a team as a code owner November 18, 2024 02:06
@mikealfare mikealfare marked this pull request as draft November 19, 2024 23:06
@mikealfare
Merge branch 'main' into move-to-pyproject
c4dd3af 
# Conflicts:
#	.bumpversion.cfg
@mikealfare mikealfare changed the title Move to hatch and pyproject.toml ADAP-1116: Move to hatch and pyproject.toml Dec 5, 2024
@mikealfare mikealfare marked this pull request as ready for review December 5, 2024 06:25
@mikealfare
Copy link
Contributor Author

Integration tests running against the workflow from this branch:
https://github.com/dbt-labs/dbt-bigquery/actions/runs/12216250826

@mikealfare mikealfare merged commit e1b6e74 into main Dec 11, 2024
13 of 15 checks passed
@mikealfare mikealfare deleted the move-to-pyproject branch December 11, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

Assignees

@mikealfare mikealfare

Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikealfare @colin-rogers-dbt